✨remove ForceSemverUpgradeConstraints feature gate and implementation #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
+ Coverage 66.76% 66.78% +0.02%
==========================================
Files 57 57
Lines 4600 4585 -15
==========================================
- Hits 3071 3062 -9
+ Misses 1303 1299 -4
+ Partials 226 224 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -28,7 +22,7 @@ func SuccessorsOf(installedBundle ocv1.BundleMetadata, channels ...declcfg.Chann | |||
| return nil, fmt.Errorf("parsing installed version constraint %q: %w", installedBundleVersion.String(), err) | |||
| } | |||
|
|
|||
| successorsPredicate, err := successors(installedBundle, channels...) | |||
| successorsPredicate, err := legacySuccessor(installedBundle, channels...) | |||
There was a problem hiding this comment.
Hi @joelanford
Any reason why we should not remove the unused funcs raised by the lint?
There was a problem hiding this comment.
Nope! Pushed an amended commit to fix.
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
rm-force-semver-upgrade-graph
branch
from
a815014 to
cfb2c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1615
Reviewer Checklist