Skip to content

📖 Add go version information to contributing #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jan 23, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner January 23, 2025 20:14
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6e10e18
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6792ba63cfc09a0008b0e6d6
😎 Deploy Preview https://deploy-preview-1648--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort tmshort changed the title 📖 Add go version information to conributing 📖 Add go version information to contributing Jan 23, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jan 23, 2025

How can this be failing the upgrade-e2e‽‽

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (c1a8f7d) to head (6e10e18).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1648      +/-   ##
==========================================
- Coverage   67.42%   67.31%   -0.11%     
==========================================
  Files          55       55              
  Lines        4632     4632              
==========================================
- Hits         3123     3118       -5     
- Misses       1284     1288       +4     
- Partials      225      226       +1     
Flag Coverage Δ
e2e 53.21% <ø> (-0.09%) ⬇️
unit 54.33% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
Copy link

openshift-ci bot commented Jan 23, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@perdasilva perdasilva added this pull request to the merge queue Jan 24, 2025
Merged via the queue into operator-framework:main with commit a46ff7d Jan 24, 2025
21 of 22 checks passed
@tmshort tmshort deleted the go-ver branch January 24, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants