Skip to content

🐛 Unblock e2e #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Jan 31, 2025

Description

This PR:

  • drops the ginkgo CLI from bingo in favor of the go run github.com/onsi/ginkgo/v2/ginkgo option, and
  • pulls in leader election e2e fix commit

Ginkgo issue:

There must be parity between the ginkgo cli running the test and the version of ginkgo used for when compiling the tests, or it complains, e.g.:

 Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.22.0
  Mismatched package versions found:
    2.22.2 used by upgrade
  Ginkgo will continue to attempt to run but you may see errors (including flag
  parsing errors) and should either update your go.mod or your version of the
  Ginkgo CLI to match.
  To install the matching version of the CLI run
    go install github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file.  Alternatively you can use
    go run github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file to invoke the matching version of the
  Ginkgo CLI.
  If you are attempting to test multiple packages that each have a different
  version of the Ginkgo library with a single Ginkgo CLI that is currently
  unsupported.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@perdasilva perdasilva marked this pull request as ready for review January 31, 2025 15:28
@perdasilva perdasilva requested a review from a team as a code owner January 31, 2025 15:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a403f3d
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/679cf9b682b11a0009e53cb5
😎 Deploy Preview https://deploy-preview-1683--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tmshort
tmshort previously approved these changes Jan 31, 2025
@perdasilva perdasilva changed the title 🐛 Bump ginkgo CLI version 🐛 Drop ginkgo cli from bingo Jan 31, 2025
camilamacedo86
camilamacedo86 previously approved these changes Jan 31, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
camilamacedo86
camilamacedo86 previously approved these changes Jan 31, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
TestClusterExtensionAfterOLMUpgrade was failing due to increased leader
election timeouts, causing reconciliation checks to run before leadership
was acquired.

This fix ensures the test explicitly waits for leader election logs
(`"successfully acquired lease"`) before verifying reconciliation.
@perdasilva perdasilva changed the title 🐛 Drop ginkgo cli from bingo 🐛 Unblock e2e Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (e77c53c) to head (a403f3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
+ Coverage   67.50%   67.55%   +0.04%     
==========================================
  Files          57       57              
  Lines        4632     4632              
==========================================
+ Hits         3127     3129       +2     
+ Misses       1278     1277       -1     
+ Partials      227      226       -1     
Flag Coverage Δ
e2e 53.48% <ø> (+0.08%) ⬆️
unit 54.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into operator-framework:main with commit b5de66a Jan 31, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants