-
Notifications
You must be signed in to change notification settings - Fork 64
🐛 Unblock e2e #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Unblock e2e #1683
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8ce7499
to
862ca63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
862ca63
to
d5552a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
d5552a6
to
a9f760b
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
a9f760b
to
1bc935e
Compare
TestClusterExtensionAfterOLMUpgrade was failing due to increased leader election timeouts, causing reconciliation checks to run before leadership was acquired. This fix ensures the test explicitly waits for leader election logs (`"successfully acquired lease"`) before verifying reconciliation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
+ Coverage 67.50% 67.55% +0.04%
==========================================
Files 57 57
Lines 4632 4632
==========================================
+ Hits 3127 3129 +2
+ Misses 1278 1277 -1
+ Partials 227 226 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Per Goncalves da Silva <[email protected]>
08e60e3
to
a403f3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
This PR:
go run github.com/onsi/ginkgo/v2/ginkgo
option, andGinkgo issue:
There must be parity between the ginkgo cli running the test and the version of ginkgo used for when compiling the tests, or it complains, e.g.:
Reviewer Checklist