Skip to content

🌱 (cleanup): Removing unused consts from catalogd/test/e2e/unpack_test.go #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner February 5, 2025 21:11
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1c03e40
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67a3d43a1d1a9c0008d01dac
😎 Deploy Preview https://deploy-preview-1715--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86 camilamacedo86 changed the title 🌱 Removing unused variables 🌱 (cleanup): Removing unused consts from catalogd/test/e2e/unpack_test.go Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.64%. Comparing base (dcf50b8) to head (1c03e40).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   67.66%   67.64%   -0.03%     
==========================================
  Files          59       59              
  Lines        4991     4991              
==========================================
- Hits         3377     3376       -1     
- Misses       1367     1368       +1     
  Partials      247      247              
Flag Coverage Δ
e2e 53.38% <ø> (ø)
unit 55.39% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into operator-framework:main with commit 8493115 Feb 5, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants