🌱 (cleanup): Remove 'make vet' from Makefile, simplify; keep 'vet' enabled in linting #1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
c/c @joelanford |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 67.66% 67.66%
=======================================
Files 59 59
Lines 4991 4991
=======================================
Hits 3377 3377
Misses 1367 1367
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
reviewed
Feb 5, 2025
Makefile
Outdated
| @@ -151,7 +147,7 @@ verify-crd-compatibility: $(CRD_DIFF) manifests | |||
|
|
|||
|
|
|||
| .PHONY: test | |||
| test: manifests generate fmt vet test-unit test-e2e #HELP Run all tests. | |||
| test: manifests generate fmt test-unit test-e2e #HELP Run all tests. | |||
camilamacedo86
commented
Feb 6, 2025
perdasilva
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'make vet' from Makefile, simplify; keep 'vet' enabled in linting