🌱 (cleanup): Refactor metrics endpoint tests by extracting shared helpers #1719
Conversation
camilamacedo86
changed the title
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camilamacedo86
force-pushed
the
cleanup-metrics-tests
branch
7 times, most recently
from
89697b8 to
6a2c1d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
+ Coverage 67.58% 67.87% +0.29%
==========================================
Files 59 59
Lines 4982 4993 +11
==========================================
+ Hits 3367 3389 +22
+ Misses 1371 1362 -9
+ Partials 244 242 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camilamacedo86
force-pushed
the
cleanup-metrics-tests
branch
from
6a2c1d8 to
99d28af
Compare
test/e2e/metrics_test.go
Outdated
| config.createMetricsClusterRoleBinding() | ||
| token := config.getServiceAccountToken() | ||
| config.createCurlMetricsPod() | ||
| config.validate(token) | ||
| defer config.cleanup() |
There was a problem hiding this comment.
Maybe add a config.run() that encapsulates these calls since they look the same in both tests?
There was a problem hiding this comment.
Done !!!
Good call.
…hared helpers Refactored the metrics endpoint tests by introducing reusable helper functions. This reduces duplication and improves maintainability across both tests.
camilamacedo86
force-pushed
the
cleanup-metrics-tests
branch
from
99d28af to
42ab2ea
Compare
|
@joelanford Not adding to the merge queue incase you want to take another look. |
|
Hi @LalatenduMohanty @joelanford I am moving forward. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Refactored the metrics endpoint tests by introducing reusable helper functions. This reduces duplication and improves maintainability across both tests.
Motivated by: #1712