🐛 (catalogd) serveJSON lines instead of http.serverContent for no-params
#1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
reviewed
Feb 6, 2025
| @@ -244,7 +244,7 @@ func (s *LocalDirV1) handleV1Query(w http.ResponseWriter, r *http.Request) { | |||
| if schema == "" && pkg == "" && name == "" { | |||
| // If no parameters are provided, return the entire catalog (this is the same as /api/v1/all) | |||
| w.Header().Add("Content-Type", "application/jsonl") | |||
There was a problem hiding this comment.
You can remove this line, since serveJSONLines does it.
joelanford
changed the title
serveJSON lines instead of http.serverContent for no-paramsserveJSON lines instead of http.serverContent for no-params
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
+ Coverage 67.58% 67.61% +0.03%
==========================================
Files 59 59
Lines 4982 4981 -1
==========================================
+ Hits 3367 3368 +1
+ Misses 1371 1369 -2
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…arams The metas endpoint was using `serverJSONLines` for serving queries that are parameterized, which copies content from a reader to the response writer under the hood. As a result no-parameterized query responses don't have range request support. The endpoint was however using `http.ServeContent` for cases when no parameters were provided, which does have range request support. This PR switches the `http.ServeContent` out for `serveJSONLines` to make sure metas endpoint is consistent in it's lack of support for range requests. Signed-off-by: Anik Bhattacharjee <[email protected]>
anik120
force-pushed
the
catalogd-metas-endpoint-remove-range-support
branch
from
740d117 to
f88c3b8
Compare
|
/lgtm |
joelanford
approved these changes
Feb 6, 2025
Merged
via the queue into
operator-framework:main
with commit Feb 6, 2025
f6b1130
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metas endpoint was using
serverJSONLinesfor serving queries that are parameterized, which copies content from a reader to the response writer under the hood. As a result no-parameterized query responses don't have range request support.The endpoint was however using
http.ServeContentfor cases when no parameters were provided, which does have range request support.This PR switches the
http.ServeContentout forserveJSONLinesto make sure metas endpoint is consistent in it's lack of support for range requests.Description
Reviewer Checklist