Skip to content

🐛 fix catalogd binary version output. #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

camilamacedo86
Copy link
Contributor

Follow up of: #1728

Issue (before change)

make build

/Library/Developer/CommandLineTools/usr/bin/make -C catalogd generate
stat /Users/camilam/go/src/github/operator-framework/operator-controller/catalogd/internal/version: directory not found


Aft

After change:

The version has been obtained properly:

go build -tags 'containers_image_openpgp' -ldflags '-s -w -X "github.com/operator-framework/operator-controller/internal/version.gitVersion=v1.2.0-rc4-24-gd72e551-dirty" -X "github.com/operator-framework/operator-controller/internal/version.gitCommit=d72e5518c1605bde9359f643c44934c9885fdadf" -X "github.com/operator-framework/operator-controller/internal/version.gitTreeState=dirty" -X "github.com/operator-framework/operator-controller/internal/version.commitDate=2025-02-07T14:09:09Z"' -gcflags 'all=-trimpath=/Users/camilam/go/src/github/operator-framework/operator-controller/catalogd' -asmflags 'all=-trimpath=/Users/camilam/go/src/github/operator-framework/operator-controller/catalogd' -o bin/catalogd ./cmd/catalogd

 $ ./bin/catalogd --version
"version: \"(devel)\", commit: \"d72e5518c1605bde9359f643c44934c9885fdadf\", date: \"2025-02-07T14:09:09Z\", state: \"dirty\""

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner February 10, 2025 09:42
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit ac3dede
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67aa274f526f4b000890d54a
😎 Deploy Preview https://deploy-preview-1732--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (a9f402b) to head (ac3dede).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1732   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          58       58           
  Lines        4988     4988           
=======================================
  Hits         3403     3403           
  Misses       1343     1343           
  Partials      242      242           
Flag Coverage Δ
e2e 52.92% <ø> (ø)
unit 55.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@perdasilva perdasilva enabled auto-merge February 10, 2025 16:24
@perdasilva perdasilva added this pull request to the merge queue Feb 10, 2025
auto-merge was automatically disabled February 10, 2025 16:48

Pull Request is not mergeable

Merged via the queue into operator-framework:main with commit ce837d6 Feb 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants