🌱 Moving pkgs to internal/operator-controller/ #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LalatenduMohanty
force-pushed
the
issue_1707
branch
from
8b923bf to
5d1d1a2
Compare
openshift-merge-robot
removed
the
needs-rebase
LalatenduMohanty
force-pushed
the
issue_1707
branch
from
5d1d1a2 to
edbac13
Compare
I am consolidating |
LalatenduMohanty
force-pushed
the
issue_1707
branch
2 times, most recently
from
4c09b1a to
8cf1eea
Compare
openshift-merge-robot
added
the
needs-rebase
LalatenduMohanty
force-pushed
the
issue_1707
branch
2 times, most recently
from
79d7aea to
b173eb1
Compare
openshift-merge-robot
removed
the
needs-rebase
LalatenduMohanty
force-pushed
the
issue_1707
branch
from
b173eb1 to
685c80e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 61 61
Lines 5236 5236
=======================================
Hits 3526 3526
Misses 1449 1449
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LalatenduMohanty
force-pushed
the
issue_1707
branch
from
685c80e to
0cb270e
Compare
LalatenduMohanty
changed the title
camilamacedo86
previously approved these changes
Feb 11, 2025
This partially fixes operator-framework#1707. The intent is to consolidate internal code from operator-controller and catalogd within internal e.g.: catalogd/ - code specific to catalogd internal/ - holds internal code of catalogd and operator-controller. internal/catalogd - holds unexported code specific to catalogd internal/operator-controller - holds unexported code specific to operator-comntroller internal/shared - shared code between catalogd and operator-controller which can not be exported outside. Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
issue_1707
branch
from
0cb270e to
7612bd7
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #1707. The intent is to consolidate internal code from operator-controller and catalogd within internal e.g.:
catalogd/ - code specific to catalogd
internal/ - holds internal code of catalogd and operator-controller. internal/catalogd - holds unexported code specific to catalogd internal/operator-controller - holds unexported code specific to operator-comntroller internal/shared - shared code between catalogd and operator-controller which can not be exported outside.
Description
Reviewer Checklist