Skip to content

🌱 [Monorepo]: Move the hack demo scripts to the root #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

🌱 [Monorepo]: Move the hack demo scripts to the root #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/catalogd-demo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,5 @@ jobs:
with:
go-version-file: "go.mod"
- name: Run Demo Update
working-directory: catalogd
run: make demo-update

5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,4 +407,9 @@ deploy-docs: venv
. $(VENV)/activate; \
mkdocs gh-deploy --force

# The demo script requires to install asciinema with: brew install asciinema to run on mac os envs.
.PHONY: demo-update #EXHELP build demo
demo-update:
./hack/demo/generate-asciidemo.sh

include Makefile.venv
6 changes: 0 additions & 6 deletions catalogd/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,3 @@ build-container: build-linux ## Build docker image for catalogd.
kind-load: $(KIND) ## Load the built images onto the local cluster
$(CONTAINER_RUNTIME) save $(IMAGE) | $(KIND) load image-archive /dev/stdin --name $(KIND_CLUSTER_NAME)

##@ Deploy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's apparently no Deploy section in the op-con Makefile help. :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the demo should be under the doc section as it is right?
Should we create a Deploy section
Does it make sense we add it there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the demo-update now

$ make 
bash                          clean-venv                    fix-lint                      kind-cluster                  release                       test-ext-dev-e2e
bingo-upgrade                 crd-ref-docs                  fmt                           kind-deploy                   run                           test-unit
build                         debug-venv                    generate                      kind-load                     run-latest-release            test-upgrade-e2e
build-deps                    demo-update                   go-build-linux                lint                          serve-docs                    tidy
build-docs                    deploy-docs                   go-build-local                manifests                     shell                         venv
build-linux                   docker-build                  help                          operator-controller           show-venv                     verify
catalogd-e2e                  e2e                           help-extended                 post-upgrade-checks           test                          verify-crd-compatibility
catalogd-image-registry       e2e-coverage                  image-registry                pre-upgrade-setup             test-catalogd-e2e             wait
catalogd-post-upgrade-checks  envtest-k8s-bins              ipython                       python                        test-catalogd-upgrade-e2e     zsh
catalogd-pre-upgrade-setup    extension-developer-e2e       kind-clean


# The demo script requires to install asciinema with: brew install asciinema to run on mac os envs.
.PHONY: demo-update #HELP build demo
demo-update:
hack/scripts/generate-asciidemo.sh
0 catalogd/hack/scripts/demo-script.sh → hack/demo/demo-script.sh
View file
Open in desktop
File renamed without changes.
0 catalogd/hack/scripts/generate-asciidemo.sh → hack/demo/generate-asciidemo.sh
View file
Open in desktop
File renamed without changes.
0 ...d/hack/scripts/generate-gzip-asciidemo.sh → hack/demo/generate-gzip-asciidemo.sh
View file
Open in desktop
File renamed without changes.
0 catalogd/hack/scripts/gzip-demo-script.sh → hack/demo/gzip-demo-script.sh
View file
Open in desktop
File renamed without changes.
Loading