🌱 Moving code from catalogd/internal to internal/catalogd #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LalatenduMohanty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 61 61
Lines 5236 5236
=======================================
Hits 3526 3526
Misses 1449 1449
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
requested changes
Feb 11, 2025
|
/hold looks like we are not generating catalogd manifests with this change operator-controller/catalogd/Makefile Line 64 in 16085ae |
openshift-ci
bot
added
the
do-not-merge/hold
LalatenduMohanty
force-pushed
the
catalogd_internal_issue_1707
branch
from
e6b4d3a to
14ebe86
Compare
4 tasks
LalatenduMohanty
force-pushed
the
catalogd_internal_issue_1707
branch
2 times, most recently
from
fbfd13f to
0e34fae
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This partially fixes operator-framework#1707. The intent is to consolidate internal code from operator-controller and catalogd within internal. This PR does not move catalogd/internal/controllers and catalogd/internal/webhook as it need explict changes in both op-con and catalogd Makefile. Which we will do in a followup PR. catalogd/ - code specific to catalogd internal/ - holds internal code of catalogd and operator-controller. internal/catalogd - holds unexported code specific to catalogd internal/operator-controller - holds unexported code specific to operator-comntroller internal/shared - shared code between catalogd and operator-controller which can not be exported outside. Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
catalogd_internal_issue_1707
branch
from
0e34fae to
101535e
Compare
camilamacedo86
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
The request changed by @joelanford is done now
It is passing in the CI and it is as we agreed upon
So,
/lgtm
joelanford
approved these changes
Feb 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #1707. The intent is to consolidate internal code from operator-controller and catalogd within internal.
This PR does not move catalogd/internal/controllers and
catalogd/internal/webhook as it need explict changes in both op-con and
catalogd Makefile. Which we will do in a followup PR.
Description
Reviewer Checklist