🌱 Make generate-asciidemo.sh generic #1755
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -36,4 +36,3 @@ curl -k https://localhost:8081/catalogs/operatorhubio/api/v1/all | jq -s '.[] | | |||
| curl -k https://localhost:8081/catalogs/operatorhubio/api/v1/all | jq -s '.[] | select(.schema == "olm.channel") | select(.package == "wavefront") | .name' | |||
| # check what bundles are included in the wavefront package | |||
| curl -k https://localhost:8081/catalogs/operatorhubio/api/v1/all | jq -s '.[] | select(.schema == "olm.bundle") | select(.package == "wavefront") | .name' | |||
|
|
|||
There was a problem hiding this comment.
👍 It is OK, but we might want to have a complete demo instead of keep just for catalogd.
However, until there, why not? Who knows, we change the intention as well.
There was a problem hiding this comment.
The intention here is that I'm creating demo scripts for the own/single namespace install mode feature, which I'll add to the demos directory. I'll probably add a Makefile at some point.
|
/lgtm cancel |
perdasilva
force-pushed
the
refactor-demo-dir
branch
2 times, most recently
from
93208d6 to
be8c527
Compare
perdasilva
force-pushed
the
refactor-demo-dir
branch
from
be8c527 to
fc58782
Compare
Signed-off-by: Per G. da Silva <[email protected]>
perdasilva
force-pushed
the
refactor-demo-dir
branch
from
3d75a99 to
d25b00b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
=======================================
Coverage 67.45% 67.45%
=======================================
Files 61 61
Lines 5245 5245
=======================================
Hits 3538 3538
Misses 1446 1446
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Makes generate-asciidemo.sh generic to make it easier to create demo scripts and generate asciinema out of them for PRs and demos, etc.
The motivation for this change is: I was creating a demo script for the single/own namespace feature and noticed duplication in the "generate_asciinema" scripts where the only difference was the demo script being called. Hopefully, this little script helps us make demos easier =D
Reviewer Checklist