Skip to content

🌱 [Monorepo]: Cleanup: Merge catalogd-e2e tests into operator-controller e2e #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Feb 13, 2025

  • Removed gingko and omega from unpack_test.
  • Ensured that unpack_test previously under catalogd-e2e is now executed alongside other operator-controller e2e tests.

Partial from: #1712

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner February 13, 2025 12:51
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c06d09a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67af8ab684265c00082070ff
😎 Deploy Preview https://deploy-preview-1757--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86 camilamacedo86 changed the title 🌱 [Monorepo]: Cleanup: Merge catalogd-e2e tests into operator-controller e2e WIP: 🌱 [Monorepo]: Cleanup: Merge catalogd-e2e tests into operator-controller e2e Feb 13, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
@camilamacedo86 camilamacedo86 changed the title WIP: 🌱 [Monorepo]: Cleanup: Merge catalogd-e2e tests into operator-controller e2e IGNORE Feb 13, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
@camilamacedo86 camilamacedo86 changed the title IGNORE WIP Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (becde51) to head (c06d09a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
+ Coverage   67.45%   68.38%   +0.93%     
==========================================
  Files          61       63       +2     
  Lines        5245     5115     -130     
==========================================
- Hits         3538     3498      -40     
+ Misses       1446     1388      -58     
+ Partials      261      229      -32     
Flag Coverage Δ
e2e 51.75% <ø> (-0.40%) ⬇️
unit 55.93% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camilamacedo86 camilamacedo86 changed the title WIP [Monorepo]: Cleanup: Merge catalogd-e2e tests into operator-controller e2e Feb 13, 2025
@camilamacedo86 camilamacedo86 changed the title [Monorepo]: Cleanup: Merge catalogd-e2e tests into operator-controller e2e 🌱 [Monorepo]: Cleanup: Merge catalogd-e2e tests into operator-controller e2e Feb 13, 2025
perdasilva
perdasilva previously approved these changes Feb 14, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Feb 14, 2025
@camilamacedo86 camilamacedo86 removed this pull request from the merge queue due to a manual request Feb 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
…ller` e2e

- Removed `gingko` and `omega` from `unpack_test`.
- Ensured that `unpack_test` previously under `catalogd-e2e` is now executed alongside other `operator-controller` e2e tests.
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Generally looks fine to me.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
@tmshort tmshort added this pull request to the merge queue Feb 14, 2025
Merged via the queue into operator-framework:main with commit 7146a7a Feb 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants