Skip to content

🌱 [Bingo upgrade] - Update tooling versions used #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner February 17, 2025 20:44
Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 48e48f0
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67b39f9d30252f00081dc747
😎 Deploy Preview https://deploy-preview-1787--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -1,7 +1,7 @@
module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.22.1
go 1.23.0
Copy link
Contributor Author

@camilamacedo86 camilamacedo86 Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmshort this one will make fail in the check but I understand that it is OK because we have the version already.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.32%. Comparing base (e7dabc2) to head (48e48f0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
- Coverage   68.34%   68.32%   -0.02%     
==========================================
  Files          63       63              
  Lines        5117     5117              
==========================================
- Hits         3497     3496       -1     
- Misses       1390     1391       +1     
  Partials      230      230              
Flag Coverage Δ
e2e 51.62% <ø> (-0.08%) ⬇️
unit 55.89% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The go-verdiff test failed with:

Found golang version: 1.23.4
./.bingo/go.mod: Skipping, no version found
./.bingo/golangci-lint.mod: 1.23.0: Updated golang version from 1.22.1

Since we are already at 1.23.4 as our high water mark, I see no harm in bumping golangci-lint to a version that requires 1.23.0.

@camilamacedo86 camilamacedo86 added this pull request to the merge queue Feb 18, 2025
Merged via the queue into operator-framework:main with commit d35320a Feb 18, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants