-
Notifications
You must be signed in to change notification settings - Fork 64
🌱 [Bingo upgrade] - Update tooling versions used #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [Bingo upgrade] - Update tooling versions used #1787
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -1,7 +1,7 @@ | |||
module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT | |||
|
|||
go 1.22.1 | |||
go 1.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmshort this one will make fail in the check but I understand that it is OK because we have the version already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
==========================================
- Coverage 68.34% 68.32% -0.02%
==========================================
Files 63 63
Lines 5117 5117
==========================================
- Hits 3497 3496 -1
- Misses 1390 1391 +1
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The go-verdiff test failed with:
Found golang version: 1.23.4
./.bingo/go.mod: Skipping, no version found
./.bingo/golangci-lint.mod: 1.23.0: Updated golang version from 1.22.1
Since we are already at 1.23.4 as our high water mark, I see no harm in bumping golangci-lint to a version that requires 1.23.0.
d35320a
Description
Reviewer Checklist