✨ Cleanup catalogd remnants in unit test dirs #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omit non-existent catalogd test directory from UNIT_TEST_DIRS environment variable filter. Signed-off-by: Edmund Ochieng <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
==========================================
+ Coverage 68.43% 68.49% +0.05%
==========================================
Files 63 63
Lines 5132 5132
==========================================
+ Hits 3512 3515 +3
+ Misses 1390 1388 -2
+ Partials 230 229 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
approved these changes
Feb 28, 2025
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit non-existent catalogd test directory from UNIT_TEST_DIRS environment variable filter.
Description
Update the UNIT_TEST_DIRS environment variable to remove references to the
catalogd/tests/which no longer exist following the monorepo work detailed in issue #1646Reviewer Checklist