Skip to content

🐛 Revert "🐛 Client go version metrics endpoint test" #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

camilamacedo86
Copy link
Contributor

Reverts #1821
Why:

Shows that broke downstream sync:

Container test exited with code 2, reason Error
---
AtLYimWkz7DCOeuqaA7PrCJS-wbhXQmD8O1rXmdeLmiqDOBD3_ozJIEpthKERXszTlhIvwTHnGzNBTQ0A_8NBOuk0cjndJSjAS81DyAihuS6ZrfASnlygdJeHaEmGiy2o_tIaEEPMoT64gComue4IVvVHkgPnUBn2XeW38xlymDNsOC8jFWml_3bmfA3_rQa9eN1YJjAyg7Ggy_jeV7KU9v-fnDoQGWlsnQV8kXy6FYAbIb1WUGXkuSF8GmpQPGGxDKFvNwhwyjTEz-CN_X1hc2x0t3Iq8BpqBzmfNopbMwFfCFnfaSu5YxTUN95Nmgupchtw6-Q3VqwgA8uDvvETQcdzM8TLQshFOnI8ee0lf0gAHRaFlvZsE5Ubu4ecM8NG1eN-lHD3QivBUQDFFqImNx7M6O7rbYAyil_O4Tk5PUphyqBAc4nSOPseHI4SlReF85L_9dpLPEhocxx0VaoQ\r\n> \r\n{ [5 bytes data]\n* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):\n{ [122 bytes data]\n* Request completely sent off\n{ [5 bytes data]\n< HTTP/1.1 500 Internal Server Error\r\n< Content-Type: text/plain; charset=utf-8\r\n< X-Content-Type-Options: nosniff\r\n< Date: Tue, 18 Mar 2025 11:13:20 GMT\r\n< Content-Length: 22\r\n< \r\n{ [22 bytes data]\n\r100    22  100    22    0     0    738      0 --:--:-- --:--:-- --:--:--   733\r100    22  100    22    0     0    735      0 --:--:-- --:--:-- --:--:--   733\n* Connection #0 to host catalogd-service.openshift-catalogd.svc.cluster.local left intact\n" does not contain "200 OK"
        	Test:       	TestCatalogdMetricsExportedEndpoint
        	Messages:   	Metrics endpoint did not return 200 OK
    metrics_test.go:297: Cleaning up resources
    metrics_test.go:333: ClusterRoleBinding "catalogd-metrics-binding" deleted
    metrics_test.go:358: Pod "catalogd-curl-metrics" deleted
--- FAIL: TestCatalogdMetricsExportedEndpoint (6.35s)
FAIL
FAIL	github.com/operator-framework/operator-controller/test/e2e	152.432s

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner March 18, 2025 13:22
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b42b25c
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67d9737df96cb100098424d9
😎 Deploy Preview https://deploy-preview-1871--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86
Copy link
Contributor Author

@bentito @tmshort

@camilamacedo86 camilamacedo86 changed the title Revert ":bug: Client go version metrics endpoint test" 🌱 Revert ":bug: Client go version metrics endpoint test" Mar 18, 2025
@tmshort tmshort changed the title 🌱 Revert ":bug: Client go version metrics endpoint test" 🐛 Revert "🐛 Client go version metrics endpoint test" Mar 18, 2025
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@tmshort tmshort enabled auto-merge March 18, 2025 13:31
@tmshort tmshort added this pull request to the merge queue Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.98%. Comparing base (44ba340) to head (b42b25c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
+ Coverage   68.94%   68.98%   +0.03%     
==========================================
  Files          66       66              
  Lines        5236     5236              
==========================================
+ Hits         3610     3612       +2     
+ Misses       1394     1393       -1     
+ Partials      232      231       -1     
Flag Coverage Δ
e2e 50.42% <ø> (ø)
unit 56.77% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit ef348ee Mar 18, 2025
20 of 21 checks passed
@tmshort tmshort deleted the revert-1821-client-go-version-metrics-endpoint-test branch March 18, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants