🌱 adopt externally-set GO_BUILD_FLAGS #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Keister <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
+ Coverage 68.93% 68.98% +0.05%
==========================================
Files 66 66
Lines 5243 5243
==========================================
+ Hits 3614 3617 +3
+ Misses 1397 1395 -2
+ Partials 232 231 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grokspawn
changed the title
perdasilva
approved these changes
Mar 31, 2025
Merged
via the queue into
operator-framework:main
with commit Mar 31, 2025
db164cc
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Providing the capability for targets to adopt GO_BUILD_FLAGS if set in the environment. Specifically, this is useful when shifting from a compile environment which assumes no vendoring to one which assumes vendoring.
Existing uses for this were just for unit tests, so those have been shifted to a new GO_BUILD_EXTRA_FLAGS variable.
Reviewer Checklist