-
Notifications
You must be signed in to change notification settings - Fork 64
🌱 proposing github-->prow reviewer/approver mapping #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
=======================================
Coverage 69.30% 69.30%
=======================================
Files 67 67
Lines 5307 5307
=======================================
Hits 3678 3678
Misses 1397 1397
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thank you for doing this ^^
@grokspawn I'm knackered. Missed the |
/verify-owners |
Signed-off-by: Jordan Keister <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ^^ ty!! <3
Description
Contributes to
This expands the existing CODEOWNERS file to prow's OWNERS/OWNER_ALIASES files in order to be able to support our contribution ladder.
This will work with openshift/release#63229 to inform automated merge control.
Methodology was, in general...
for approvers:
for reviewers:
NOTE: There is special attention and OWNERS* files in ./docs, where @michaelryanpeter is the only approver and all other role-holders are identified as reviewers.
!! THESE ROLES SHOULD NOT BE CONSIDERED AUTHORITATIVE/FINAL !!
If your name is listed against a role that you do not feel in good conscience you can fulfill, please let me know by review comment or slack messaging.
If your name is not listed and you feel it should be, please let me know by review comment or slack messaging, including which role you feel fits.
If anything requires further consensus, we will discuss during the weekly OLM Community and Issue Triage Meeting.
Reviewer Checklist