Skip to content

🌱 proposing github-->prow reviewer/approver mapping #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Apr 2, 2025

Description

Contributes to

This expands the existing CODEOWNERS file to prow's OWNERS/OWNER_ALIASES files in order to be able to support our contribution ladder.

This will work with openshift/release#63229 to inform automated merge control.

Methodology was, in general...
for approvers:

  • expand the existing group
    for reviewers:
  • to make a quick sweep of the operator-framework member list and try to grab folks I felt confident could be considered maintainers

NOTE: There is special attention and OWNERS* files in ./docs, where @michaelryanpeter is the only approver and all other role-holders are identified as reviewers.

!! THESE ROLES SHOULD NOT BE CONSIDERED AUTHORITATIVE/FINAL !!

If your name is listed against a role that you do not feel in good conscience you can fulfill, please let me know by review comment or slack messaging.
If your name is not listed and you feel it should be, please let me know by review comment or slack messaging, including which role you feel fits.
If anything requires further consensus, we will discuss during the weekly OLM Community and Issue Triage Meeting.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@grokspawn grokspawn requested a review from a team as a code owner April 2, 2025 20:56
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a80fa2d
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67f3f5c68a11e100083e575d
😎 Deploy Preview https://deploy-preview-1894--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (1f0b4f2) to head (a80fa2d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1894   +/-   ##
=======================================
  Coverage   69.30%   69.30%           
=======================================
  Files          67       67           
  Lines        5307     5307           
=======================================
  Hits         3678     3678           
  Misses       1397     1397           
  Partials      232      232           
Flag Coverage Δ
e2e 50.55% <ø> (ø)
unit 57.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

perdasilva
perdasilva previously approved these changes Apr 4, 2025
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you for doing this ^^

@perdasilva
Copy link
Contributor

perdasilva commented Apr 4, 2025

@grokspawn I'm knackered. Missed the WIP invalid owners file. But, still, lgtm =D

@grokspawn
Copy link
Contributor Author

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 7, 2025
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ^^ ty!! <3

@grokspawn grokspawn added this pull request to the merge queue Apr 7, 2025
Merged via the queue into operator-framework:main with commit cedf1e7 Apr 7, 2025
20 checks passed
@grokspawn grokspawn deleted the prow_owners branch April 7, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants