Skip to content

✨ Log catalogd feature gate states #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Apr 18, 2025

Description

As a followup to #1858 and working from #1922 we add similar logging to the catalogd side of things.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@bentito bentito requested a review from a team as a code owner April 18, 2025 14:39
@openshift-ci openshift-ci bot requested review from gavinmbell and OchiengEd April 18, 2025 14:39
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 275cf83
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/68067934149b490008ebbe02
😎 Deploy Preview https://deploy-preview-1930--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.02%. Comparing base (02fa296) to head (275cf83).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cmd/catalogd/main.go 0.00% 3 Missing ⚠️
internal/catalogd/features/features.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
- Coverage   66.06%   66.02%   -0.05%     
==========================================
  Files          70       71       +1     
  Lines        6182     6189       +7     
==========================================
+ Hits         4084     4086       +2     
- Misses       1839     1844       +5     
  Partials      259      259              
Flag Coverage Δ
e2e 45.18% <100.00%> (-0.05%) ⬇️
unit 55.38% <70.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Apr 18, 2025

Is this already done in op-con? If if so, why isn't there shared code?

@bentito
Copy link
Contributor Author

bentito commented Apr 21, 2025

Is this already done in op-con? If if so, why isn't there shared code?

Oh hmm, because I didn't think of it. Let me see if we can change to share the code.

@bentito
Copy link
Contributor Author

bentito commented Apr 21, 2025

@tmshort, moved the feature logging func to a central locale and added a test just to make sure we're getting out what we want and honoring sorting. PTAL again.

@bentito bentito requested a review from tmshort April 21, 2025 20:45
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@tmshort tmshort added this pull request to the merge queue Apr 23, 2025
Merged via the queue into operator-framework:main with commit e3be328 Apr 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants