-
Notifications
You must be signed in to change notification settings - Fork 64
✨ Log catalogd feature gate states #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Log catalogd feature gate states #1930
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
- Coverage 66.06% 66.02% -0.05%
==========================================
Files 70 71 +1
Lines 6182 6189 +7
==========================================
+ Hits 4084 4086 +2
- Misses 1839 1844 +5
Partials 259 259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Is this already done in op-con? If if so, why isn't there shared code? |
Oh hmm, because I didn't think of it. Let me see if we can change to share the code. |
Signed-off-by: Brett Tofel <[email protected]>
@tmshort, moved the feature logging func to a central locale and added a test just to make sure we're getting out what we want and honoring sorting. PTAL again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
As a followup to #1858 and working from #1922 we add similar logging to the catalogd side of things.
Reviewer Checklist