Skip to content

🌱 Ease CI requirements for codecov patch #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented May 20, 2025

Update codecov patch threshold

We often see +/- very small changes to the patch threashold which end up reporting as a failure. Set the threshold to 1% so these -0.05% changes don't impact us as much.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Update codecov patch threshold

We often see +/- very small changes to the patch threashold which
end up reporting as a failure. Set the threshold to 1% so these
-0.05% changes don't impact us as much.
@tmshort tmshort requested a review from a team as a code owner May 20, 2025 21:06
Copy link

netlify bot commented May 20, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b70fc7f
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/682ceedd42cbab00085b09ca
😎 Deploy Preview https://deploy-preview-1982--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.06%. Comparing base (9a61b22) to head (b70fc7f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
- Coverage   69.10%   69.06%   -0.05%     
==========================================
  Files          79       79              
  Lines        7011     7011              
==========================================
- Hits         4845     4842       -3     
- Misses       1885     1887       +2     
- Partials      281      282       +1     
Flag Coverage Δ
e2e 41.42% <ø> (-0.06%) ⬇️
unit 59.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2025
@camilamacedo86
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn grokspawn merged commit 84cb9b5 into operator-framework:main May 21, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants