-
Notifications
You must be signed in to change notification settings - Fork 64
Moves ./controllers
into ./internal
and ./main.go
into ./cmd
#222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mikalai Radchuk <[email protected]>
Signed-off-by: Mikalai Radchuk <[email protected]>
Signed-off-by: Mikalai Radchuk <[email protected]>
I question moving |
The actual move looks fine to me, but I agree with @tmshort that we may not need to export anything now, but we could in the future. I think this gets into the discussion of the different supported use cases and form factors that OLMv1 could come in and is probably a discussion much to large for this PR. That being said, if we find in the future that some stuff needs to be exported we could always refactor it again |
@tmshort I would still suggest to move it to
@tmshort @everettraven I think it is easier to export something than remove publicly available API. I'm in favour of starting with as few exported things as possible and export as the need arises. |
@m1kola I think that is reasonable |
According to Spock, "I was not attempting to evaluate its moral implications, Doctor. As a matter of cosmic history, it has always been easier to destroy than to create." but not in the case of APIs. So, yeah. |
Description
./controllers
into./internal
Unless we have intention to export
./controllers
as a library - it makes sense to move this package into./internal
. If we want to expose./controllers
at some point - I would suggest moving it into./pkg
../main.go
into./cmd
We want to add more commands into the repo (Dependency Library + CLI #206, for example) so would be great to avoid having one of the entry points in the repo root
Note:
go-apidiff
will complain since we no longer export stuff from./controllers
.Reviewer Checklist