Skip to content

✨ Move helm-operator-plugin #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented May 3, 2024

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner May 3, 2024 13:57
@tmshort
Copy link
Contributor Author

tmshort commented May 3, 2024

@varshaprasad96 @joelanford This is one thing I missed in the original rukpak. The depedent.go file can also be found here:
https://github.com/operator-framework/rukpak/blob/main/internal/helm-operator-plugins/predicate/depedent.go

So, I can do this, and we have duplicate code, or I can made additional changes to rukpak...

@joelanford
Copy link
Member

joelanford commented May 3, 2024

Let's change rukpak. Also, instead of reflect we should use this: https://github.com/kubernetes/apimachinery/blob/37988e577e160bf7749437141fee1d6b8ca15dd6/pkg/api/equality/semantic.go#L28

@tmshort
Copy link
Contributor Author

tmshort commented May 3, 2024

@joelanford, I updated rukpak: operator-framework/rukpak#878
But I would consider the reflect changes separate.

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Signed-off-by: Todd Short <[email protected]>
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@tmshort tmshort merged commit d2fe0de into operator-framework:helm-poc May 3, 2024
6 of 10 checks passed
@tmshort tmshort deleted the more-rukpak branch May 3, 2024 19:39
tmshort added a commit that referenced this pull request May 3, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort mentioned this pull request May 3, 2024
4 tasks
tmshort added a commit that referenced this pull request May 6, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
varshaprasad96 pushed a commit to varshaprasad96/operator-controller that referenced this pull request May 10, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (operator-framework#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (operator-framework#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (operator-framework#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (operator-framework#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (operator-framework#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (operator-framework#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (operator-framework#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (operator-framework#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (operator-framework#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (operator-framework#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (operator-framework#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (operator-framework#806)

Remove install references to rukpak (operator-framework#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (operator-framework#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (operator-framework#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (operator-framework#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (operator-framework#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (operator-framework#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (operator-framework#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (operator-framework#833)

Signed-off-by: Todd Short <[email protected]>
tmshort added a commit that referenced this pull request May 11, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
bentito pushed a commit that referenced this pull request May 14, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants