🐛 Fixing the labels for better metrics collection #969
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 35 35
Lines 1918 1918
=======================================
Hits 1447 1447
Misses 329 329
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LalatenduMohanty
changed the title
LalatenduMohanty
changed the title
config/base/manager/manager.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| kind: Namespace | |||
| metadata: | |||
| labels: | |||
| control-plane: controller-manager | |||
| control-plane: operator-controller-controller-manager | |||
There was a problem hiding this comment.
I think I would delete this label from the namespace. catalogd contributes this same namespace in it's manifest, which means we'll end up with conflicts or silent overwrites.
This is related to #967
There was a problem hiding this comment.
So, this is a minor change that can be done fairly quickly.
There was a problem hiding this comment.
catalogd uses catalogd-controller-manager and not operator-controller-controller-manager. So I am little confused here.
There was a problem hiding this comment.
@LalatenduMohanty I think what @joelanford is saying is that both catalogd and operator-controller would create this particular namespace based on recent manifest changes across both projects
config/base/manager/manager.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| kind: Namespace | |||
| metadata: | |||
| labels: | |||
| control-plane: controller-manager | |||
| control-plane: operator-controller-controller-manager | |||
There was a problem hiding this comment.
So, this is a minor change that can be done fairly quickly.
|
Where are we with this? |
|
Looks to be still failing tests. Have we tried using prometheus with it? |
perdasilva
force-pushed
the
955
branch
2 times, most recently
from
5765470 to
3f3b5a9
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
cdf0a8a
As the label selector used for both catalogd and operator-controller metrics services is "control-plane: controller-manager". Hence changing the labels in both operator-controller and catalogd to make sure we do not overlap.
Description
Reviewer Checklist