Skip to content

Added Github workflow for running e2e tests #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

harishsurf
Copy link
Contributor

@harishsurf harishsurf commented Apr 16, 2020

Description of the change:
Added a workflow yml file that triggers a Github Action which runs our e2e-tests using kind cluster for every PR created against this repo.
This PR also adds ginkgo's Skip() as a workaround for a failing spec in catalog_e2e. See #1380 for more details

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copy link
Contributor

@benluddy benluddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up! I just have a few nits -- we should be able to flip this on soon.

@ecordell
Copy link
Member

error copying old registry file: failed to exec []string{"skopeo", "--debug", "--insecure-policy=true", "copy", "--dest-tls-verify=false", "--format=v2s2", "--dest-no-creds=true", "docker://quay.io/olmtest/catsrc-update-test:old", "docker://localhost:5000/catsrc-update:xt2t79"}: exec: "skopeo": executable file not found in $PATH

looks like we need to install skopeo in the test vm

@benluddy
Copy link
Contributor

looks like we need to install skopeo in the test vm

IIRC there is a bit more work required than that. We're tracking it here: #1380 -- I've asked Harish to temporarily mark it as skipped when it runs as part of this job so that we can get some utility from this right away.

@harishsurf harishsurf force-pushed the github-workflow branch 3 times, most recently from 52092f7 to 2eebfb7 Compare April 16, 2020 21:04
@openshift-ci-robot
Copy link
Collaborator

@harishsurf: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade b853edb link /test e2e-gcp-upgrade
ci/prow/e2e-gcp b853edb link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell
Copy link
Member

/lgtm
/approve

infra-only, upstream-only, merging without full checks

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, harishsurf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@ecordell ecordell merged commit 9359c4f into operator-framework:master Apr 17, 2020
@harishsurf harishsurf deleted the github-workflow branch April 17, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants