WIP: refactor resolution sync #2400
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
njhale
force-pushed
the
fix/flappy-subs
branch
2 times, most recently
from
7f9251a to
2239029
Compare
| shouldUpdate := false | ||
| for _, sub := range subs { | ||
| shouldUpdate = shouldUpdate || !o.nothingToUpdate(logger, sub) | ||
| if o.sourcesLastUpdate.Before(lastResolution.Time) { |
There was a problem hiding this comment.
As we discussed this on the Slack thread, blocking resolution on unreliable timestamp is problematic. I have recently remove this timestamp check due to blocked/delayed upgrade when subscription spec change. The only time we should skip resolution is where there is a pending installation which is checked above this.
There was a problem hiding this comment.
@dinhxuanvu we've noted hotlooping in this sync handler in master. I'm not convinced it's unrelated to the removal of the timestamp check.
There was a problem hiding this comment.
I need to check out what hotloop situation that you are referring to. However, given if there is nothing changed, resolver should resolve into nothing which in turn shouldn't lead into any subscription changes. I'm not convinced just because we let resolver run whenever namespace sync happens will cause hotlooping. If we are talking about too many resync, then there is a ratelimiting setting for this in place if I recall correctly.
Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
fix/flappy-subs
branch
from
2239029 to
05de665
Compare
openshift-ci
bot
added
the
needs-rebase
|
@njhale: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing out for now. Will try again at some point. |
Description of the change:
An attempt to simplify resolution syncing.