Makefile: Reduce flake attempts when running the e2e suite in CI #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update the `e2e-local` Makefile target and reduce the number of flake attempts that will be attempted to a single test failure. This should help weed out any tests that are flake-prone and need to be updated in order to increase signal during individual CI runs, along with any real problematic tests that masking regressions due to re-running any failed test multiple times. Signed-off-by: timflannagan <[email protected]>
timflannagan
force-pushed
the
reduce-flake-attempts
branch
from
ab0cc03 to
4eb6085
Compare
|
Closing in favor of #2393 which also sets the default to a single flake attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the
e2e-localMakefile target and reduce the number of flakeattempts that will be attempted to a single test failure. This should
help weed out any tests that are flake-prone and need to be updated in
order to increase signal during individual CI runs, along with any real
problematic tests that masking regressions due to re-running any failed
test multiple times.
Signed-off-by: timflannagan [email protected]
Motivation for the change:
Reviewer Checklist
/doc