Skip to content

Fix Rename ClusterRoles created by OperatorGroups issues. #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix Rename ClusterRoles created by OperatorGroups issues. #3048

merged 1 commit into from
Oct 3, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 2, 2023 •
edited
Loading

Remove unused function.
Remove possibly verbose log statement.

Fixes #3047

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@tmshort
Fix Rename ClusterRoles created by OperatorGroups issues.
bdef086 
Remove unused function.
Remove possibly verbose log statement.

Signed-off-by: Todd Short <[email protected]>
@openshift-ci openshift-ci bot requested review from anik120 and dtfranz October 2, 2023 21:37
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@tmshort
Copy link
Contributor Author

tmshort commented Oct 2, 2023

Fixes issues in #3035

@tmshort tmshort mentioned this pull request Oct 2, 2023
Merged
@stevekuznetsov stevekuznetsov added this pull request to the merge queue Oct 3, 2023
awgreene
awgreene approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Merged via the queue into operator-framework:master with commit fa51d6f Oct 3, 2023
@tmshort tmshort deleted the quick-fix branch October 3, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene awgreene approved these changes

@anik120 anik120 Awaiting requested review from anik120

@dtfranz dtfranz Awaiting requested review from dtfranz

Assignees

@awgreene awgreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused code
3 participants
@tmshort @awgreene @stevekuznetsov