Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Apr 1, 2024

Required one-line code change

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from grokspawn and oceanc80 April 1, 2024 18:36
@tmshort
Copy link
Contributor Author

tmshort commented Apr 1, 2024

Note: This does not update operator-framework/api or operator-framework/operator-registry references, which have yet to move to k8s v0.29.x, but there are PRs for it (i.e. operator-framework/api#319, operator-framework/operator-registry#1244 and operator-framework/operator-registry#1244)

Required one-line code change

Signed-off-by: Todd Short <[email protected]>
@grokspawn grokspawn added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2024
@tmshort tmshort added this pull request to the merge queue Apr 2, 2024
Merged via the queue into operator-framework:master with commit 81eef3a Apr 2, 2024
@tmshort tmshort deleted the k8s-bump branch April 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants