update go tutorial docs to reflect call to NewManager func

[komish]

Signed-off-by: Jose R. Gonzalez [email protected]

Description of the change:

With v1.0, the scaffolding creates a manager with some default options using "sigs.k8s.io/controller-runtime".NewManager() (changed from "sigs.k8s.io/controller-runtime/pkg/manager".New()) This seems to be accounted for in other places in the docs.

Motivation for the change:

Thought it might help with consistency across the documentation. Not sure if the Tutorial in its current form was going to stick around but figured I'd send this PR either way and we just close if it not.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• Add or update relevant sections of the docs website in website/content/en/docs

[camilamacedo86]

/lgtm

good catcher 👍

[jmrodri]

/lgtm

[estroz]

There is no controller-runtime.pkg/manager.NewManager() constructor, perhaps you're thinking of controller-runtime.NewManager()? If so, we need to also update the import alias from manager to ctrl, which is what main.go uses.

Canceling my review as @estroz pointed out, there's a problem here.

[camilamacedo86]

Hi @estroz,

The first comment shows a little confuse. But the change here is just to fix the constructor in the examples to be consistent with the new code that is scaffolded. Replace manager.New With manager.NewManager.

[komish]

I'm seeing the following import in a main.go from operator-sdk 0.18 (i.e. "old state")

import (
// ... other imports here
	"sigs.k8s.io/controller-runtime/pkg/manager"
)

I see it used to create a manager like so:

	// Create a new manager to provide shared dependencies and start components
	mgr, err := manager.New(cfg, options)
	if err != nil {
		log.Error(err, "")
		os.Exit(1)
	}

New state does refer to the import of controller-runtime as ctrl and ctrl.NewManager() used to get the manager unless I'm misunderstanding. Either way - I can update this to ctrl in the docs as well if that's the desired outcome @estroz is detailing.

Can you confirm? If so, I'll push straight away.

[camilamacedo86]

Suggested change

	mgr, err := manager.NewManager(cfg, manager.Options{Namespace: namespace})
	mgr, err := ctrl.NewManager(cfg, manager.Options{Namespace: namespace})

[camilamacedo86]

Suggested change

	mgr, err := manager.NewManager(cfg, manager.Options{Namespace: ""})
	mgr, err := ctrl.NewManager(cfg, manager.Options{Namespace: ""})

[camilamacedo86]

Suggested change

	mgr, err := manager.NewManager(cfg, manager.Options{
	mgr, err := ctrl.NewManager(cfg, manager.Options{

[komish]

Got it. Updating and pushing momentarily.

[estroz]

Thanks!

/lgtm

[komish]

Should be good to go!