Use k8s.io/utils set instead of apimachinery sets #6486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everettraven
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Thanks @skitt for the contribution! The changes seem pretty straightforward and reasonable to me
/lgtm
|
The unit test failure is fixed by kubernetes/utils#286. |
Following kubernetes/utils#243 it's likely that the k8s.io/utils version will end up being the canonical one. Signed-off-by: Stephen Kitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Use the
k8s.io/utilsimplemention ofsetrather than theapimachinerysets.Motivation for the change:
Following kubernetes/utils#243 it's likely that the k8s.io/utils version will end up being the canonical one.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs