Skip to content

ci: Added coveralls #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2020
Merged

ci: Added coveralls #250

merged 3 commits into from
Jul 16, 2020

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Jul 14, 2020 •
edited
Loading

Summary

  • Replaced codecove.io to coveralls.

TestPlan

  • All UT and FSC must pass
  • Check should be available for coveralls.

@msohailhussain msohailhussain changed the title WIP - test coveralls ci: Added coveralls Jul 15, 2020
@msohailhussain msohailhussain marked this pull request as ready for review July 15, 2020 17:25
mikeproeng37
mikeproeng37 suggested changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also replace our badge in the README:

Coverage Status

mikeproeng37
mikeproeng37 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 449c3d5 into master Jul 16, 2020
@mikeproeng37 mikeproeng37 deleted the sohail/replacecodecove branch July 16, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecdavis mikecdavis Awaiting requested review from mikecdavis

@mjc1283 mjc1283 Awaiting requested review from mjc1283

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @mikeproeng37