Skip to content

Fix: build was not triggering on pushing tags #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2023
Merged

Fix: build was not triggering on pushing tags #360

merged 6 commits into from
Feb 28, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Feb 28, 2023 •
edited
Loading

Summary

  • fixed the regex to validate the tags value

@mnoman09 mnoman09 self-assigned this Feb 28, 2023
@mnoman09 mnoman09 changed the title test Fix: build was not triggering on pushing tags Feb 28, 2023
msohailhussain
msohailhussain approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit 54b5f1e into master Feb 28, 2023
@msohailhussain msohailhussain deleted the mnoman/gitactionfix branch February 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @msohailhussain @NomanShoaib