Skip to content

Conversation

thomaszurkan-optimizely
Copy link
Contributor

… starting synchronously

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a regression test for this bug so that we'll catch it if it resurfaces?

//in Cache than should be able to get from raw data file
optimizelyClient = initialize(context,getDatafile(context,datafileRes),false);
notifyStartListener();
injectOptimizely(context, userProfileService, getDatafile(context,datafileRes));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch here.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we need to update any of the dev docs for this?

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 925e570 into master Jun 5, 2018
@mikeproeng37 mikeproeng37 deleted the fix/datafileDownload branch January 15, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants