bring back getVariable(String,Integer,Double,Boolean) #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
reviewed
Jun 7, 2018
| * @return the live variable to retrieve for the given variable key | ||
| * | ||
| */ | ||
| private LiveVariable getLiveVariable(ProjectConfig projectConfig, String variableKey) { |
There was a problem hiding this comment.
I think we should null-check the variableKey since it is a user-provided input or we can do it at a higher level, like the caller of this function
| @NonNull Map<String, String> attributes, | ||
| boolean activateExperiment) { | ||
|
|
||
| if (!isValid()) { |
There was a problem hiding this comment.
Let's null-check the userId and variableKey input params here
mikeproeng37
reviewed
Jun 7, 2018
| } | ||
|
|
||
| if (variableKey == null || variableKey.isEmpty()) { | ||
| logger.warn("Invalid live variable key (null or empty) " + |
There was a problem hiding this comment.
I'd make the argument for making these error logs so the developer will be more inclined to fix it or null-check on their end before passing to us.
mikeproeng37
approved these changes
Jun 7, 2018
aliabbasrizvi
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests added as well.