Skip to content

(fix): fix so that the job service will not run if there is no internet conn… #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2019
Merged

(fix): fix so that the job service will not run if there is no internet conn… #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17f988
fix so that the job service will not run if there is no internet conn…
thomaszurkan-optimizely Aug 16, 2019
5a7d354
Merge branch 'master' into serviceTweak
thomaszurkan-optimizely Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion shared/src/main/java/com/optimizely/ab/android/shared/ServiceScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ public static void startService(Context context, Integer jobId, Intent intent) {
JobInfo jobInfo = new JobInfo.Builder(jobId,
new ComponentName(context, JobWorkService.class))
// schedule it to run any time between 1 - 5 minutes
.setMinimumLatency(JobWorkService.ONE_MINUTE)
.setMinimumLatency(0)
.setRequiredNetworkType(JobInfo.NETWORK_TYPE_ANY)
.setOverrideDeadline(5 * JobWorkService.ONE_MINUTE)
.build();
JobScheduler jobScheduler = (JobScheduler) context.getSystemService(Context.JOB_SCHEDULER_SERVICE);
Expand Down
6 changes: 4 additions & 2 deletions test-app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
-->

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.optimizely.ab.android.test_app">
xmlns:tools="http://schemas.android.com/tools"
package="com.optimizely.ab.android.test_app">

<uses-permission android:name="android.permission.DISABLE_KEYGUARD" />
<uses-permission android:name="android.permission.WAKE_LOCK" />
Expand All @@ -31,7 +32,8 @@
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:supportsRtl="true"
android:theme="@style/AppTheme">
android:theme="@style/AppTheme"
tools:ignore="GoogleAppIndexingWarning">
<service
android:name=".NotificationService"
android:exported="false" />
Expand Down