Skip to content

fix: support arbitrarily long list of user attributes in batch events #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 4, 2021
Merged

fix: support arbitrarily long list of user attributes in batch events #386

merged 13 commits into from
Oct 4, 2021

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Sep 28, 2021

Summary

  • WorkManager has 10KB limit on Data, so we cannot support batch events for a long list of attributes or large batch sizes.
  • BatchEvents are compressed/decompressed to support large events.
  • Compression/decompression is bypassed when the data size is less than the 10KB limit.

Test plan

  • Add tests for compress/decompress for a range of batch event sizes.
  • Test for backward compatibility for old OS versions.

Issues

  • "OASIS-8000"

@jaeopt jaeopt requested a review from a team as a code owner September 28, 2021 00:22
@jaeopt jaeopt removed their assignment Sep 28, 2021
@jaeopt jaeopt requested a review from mnoman09 September 28, 2021 01:07
@jaeopt jaeopt closed this Sep 28, 2021
@jaeopt jaeopt reopened this Sep 28, 2021
mnoman09
mnoman09 reviewed Sep 29, 2021
View reviewed changes
@jaeopt jaeopt closed this Sep 29, 2021
@jaeopt jaeopt reopened this Sep 29, 2021
The-inside-man
The-inside-man approved these changes Sep 29, 2021
View reviewed changes
Copy link

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one small comment for clean up of commented code

event-handler/src/main/java/com/optimizely/ab/android/event_handler/EventHandlerUtils.java Outdated
byte[] data = uncompressed.getBytes();

final Deflater deflater = new Deflater();
//deflater.setLevel(BEST_COMPRESSION);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove commented out code before moving to Master?

@jaeopt jaeopt merged commit e2abbc3 into master Oct 4, 2021
@jaeopt jaeopt deleted the jae/batch-compress branch October 4, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mnoman09 mnoman09 mnoman09 left review comments

@The-inside-man The-inside-man The-inside-man approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaeopt jaeopt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaeopt @The-inside-man @mnoman09