Skip to content

fix: change default attributes to more meaningful values #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2022
Merged

fix: change default attributes to more meaningful values #415

merged 3 commits into from
Apr 1, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Apr 1, 2022 •
edited
Loading

Summary

  • (android SDK package name) -> android SDK version
  • (app version + serail-id) -> app version

These default attributes are filtered out from events unless attributes are set in the project configuration.

@jaeopt jaeopt requested a review from a team as a code owner April 1, 2022 17:54
@jaeopt jaeopt removed their assignment Apr 1, 2022
msohailhussain
msohailhussain approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 97168d1 into master Apr 1, 2022
@jaeopt jaeopt deleted the jae/default-attrs branch April 1, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaeopt @msohailhussain