Skip to content

fix: call end inflater/deflater to avoid leaks #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2022
Merged

fix: call end inflater/deflater to avoid leaks #422

merged 3 commits into from
May 9, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Apr 28, 2022

Summary

  • StrictMode detects leaks with inflater and deflater.
  • Add end() calls at the end of inflate/deflate

Test plan

  • Pass with existing compress/decompress
  • Test with StrictMode

Issues

@jaeopt jaeopt requested a review from a team as a code owner April 28, 2022 17:34
@jaeopt jaeopt removed their assignment Apr 28, 2022
mikechu-optimizely
mikechu-optimizely reviewed Apr 28, 2022
View reviewed changes
Copy link

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finally block additions make sense to me. (comment only)

mikechu-optimizely
mikechu-optimizely approved these changes May 4, 2022
View reviewed changes
Copy link

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jaeopt jaeopt closed this May 9, 2022
@jaeopt jaeopt reopened this May 9, 2022
@jaeopt jaeopt closed this May 9, 2022
@jaeopt jaeopt reopened this May 9, 2022
@jaeopt jaeopt merged commit a12868d into master May 9, 2022
@jaeopt jaeopt deleted the jae/close-compress branch May 9, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@jaeopt jaeopt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaeopt @mikechu-optimizely