Skip to content

[FSSDK-11539] feat: holdout feature support added #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Aug 20, 2025

Summary

  • Core functionality is implemented by java-sdk.
  • Add test cases for holdout support.
  • Unit test is failing because holdout feature didn't publish yet for java.

Note

The PR would be merged into master after publishing java holdout feature.

Test plan

Issues

  • FSSDK-11539

- Remove unused and redundant test methods related to holdout behavior
- Remove 'testDecide_all_withHoldout', 'testDecisionNotificationHandler_withHoldout', 'testHoldout_zeroTraffic', and 'testHoldout_attributeFiltering' methods
@muzahidul-opti muzahidul-opti changed the title [FSSDK-0000] feat: holdout feature support added [FSSDK-11539] feat: holdout feature support added Aug 20, 2025
@muzahidul-opti muzahidul-opti marked this pull request as ready for review August 20, 2025 15:49
@muzahidul-opti muzahidul-opti requested a review from jaeopt August 20, 2025 15:49
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not 100% sure if we need this test in Android (and flutter) level.
Unless we have any reason not working in android, we can drop?

@muzahidul-opti
Copy link
Contributor Author

Looks good, but not 100% sure if we need this test in Android (and flutter) level. Unless we have any reason not working in android, we can drop?

Good point. I think so, we may drop the test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants