Skip to content

Conversation

wangjoshuah
Copy link
Contributor

  • link feature variable accessors to feature variable by value and type
  • add unit tests for getFeatureVariable calling through to internals
  • add unit tests to catch parsing error

@wangjoshuah
Copy link
Contributor Author

@optimizely/fullstack-devs

@wangjoshuah wangjoshuah force-pushed the josh.wang/link_feature_variable_accessor_apis branch from 9186b82 to 2e61284 Compare August 16, 2017 17:13
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wangjoshuah wangjoshuah merged commit 1f0e341 into master Aug 16, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/link_feature_variable_accessor_apis branch August 16, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants