Skip to content

(fix): older versions of JSONArray do not support iteration. In order to av… #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2019
Merged

(fix): older versions of JSONArray do not support iteration. In order to av… #283

merged 2 commits into from
Apr 22, 2019

Conversation

thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Apr 19, 2019 •
edited
Loading

…oid crashes in this case, we use the get(index) instead

Summary

  • Android default libraries include old org.json parsing. If you include some of these libraries which are done by default, you can end up with a crash. This fixes the exception of JSONArray not supporting iterator. The datafile does not get parsed.

The "why", or other context.

Test plan

All test pass.

Issues

  • It is related to a progruard fix going into android.

@thomaszurkan-optimizely
older versions of JSONArray do not support iteration. In order to avo…
dd7d797 
…id crashes in this case, we use the get(index) instead
@coveralls
Copy link

coveralls commented Apr 19, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 971

  • 36 of 36 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.236%
Totals Coverage Status
Change from base Build 962: 0.0%
Covered Lines: 2744
Relevant Lines: 3075
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 1f634cd into master Apr 22, 2019
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fixJsonParserWorkWithOlderVersions branch April 22, 2019 22:38
thomaszurkan-optimizely added a commit that referenced this pull request Apr 23, 2019
@thomaszurkan-optimizely
older versions of JSONArray do not support iteration. In order to avo…
fa1171b 
…id crashes in this case, we use the get(index) instead (#283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoman09 mnoman09 Awaiting requested review from mnoman09

@loganlinn loganlinn Awaiting requested review from loganlinn

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomaszurkan-optimizely @coveralls @mikeproeng37