Skip to content

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Nov 12, 2020

Summary

Fix for #622 . For the Node.js version of setTimeout, the return value isn't number, but Timeout. To allow this to typecheck regardless of whether the browser or Node.js version is used, set the type of readyTimeout to any.

Test plan

Existing tests

Issues

#622

@coveralls
Copy link

coveralls commented Nov 12, 2020

Coverage Status

Coverage remained the same at 96.706% when pulling 7888515 on mc/issue-622 into 058d0db on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.706% when pulling 67d211e on mc/issue-622 into 058d0db on master.

@mjc1283 mjc1283 merged commit 1fb0013 into master Nov 12, 2020
@mjc1283 mjc1283 deleted the mc/issue-622 branch November 12, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants