Skip to content

feat: defaultDecideOptions in SDKOptions #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2021
Merged

feat: defaultDecideOptions in SDKOptions #647

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df9537e
add defaultDecideOptions in SDKOptions
ozayr-zaviar Feb 2, 2021
d495408
comment correction
ozayr-zaviar Feb 2, 2021
2054f2b
removed undefined
msohailhussain Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/optimizely-sdk/lib/shared_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ export interface SDKOptions {
sdkKey?: string;
// user profile that contains user information
userProfileService?: UserProfileService;
// dafailt options for decide API
defaultDecideOptions?: OptimizelyDecideOption[] | undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if specifying undefined as a type is needed in this case as it is an optional parameter. WDYT @mjc1283 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, @yavorona . @ozayr-zaviar please fix.

}

export type OptimizelyExperimentsMap = {
Expand Down