Skip to content

feat: ODP Datafile Parsing #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2022
Merged

feat: ODP Datafile Parsing #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aace573
ODP Datafile Parsing
opti-jnguyen Aug 5, 2022
986e69c
Fix getAudienceSegments
opti-jnguyen Aug 5, 2022
baa63ea
Refactor allSegments as Set to ensure unique segments
opti-jnguyen Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ function evaluateSemanticVersion(condition: Condition, user: OptimizelyUserConte
);
return null;
}

return compareVersion(conditionValue, userValue);
}

Expand All @@ -395,7 +395,7 @@ function evaluateSemanticVersion(condition: Condition, user: OptimizelyUserConte
*/
function semverEqualEvaluator(condition: Condition, user: OptimizelyUserContext): boolean | null {
const result = evaluateSemanticVersion(condition, user);
if (result === null ) {
if (result === null) {
return null;
}
return result === 0;
Expand All @@ -411,7 +411,7 @@ function semverEqualEvaluator(condition: Condition, user: OptimizelyUserContext)
*/
function semverGreaterThanEvaluator(condition: Condition, user: OptimizelyUserContext): boolean | null {
const result = evaluateSemanticVersion(condition, user);
if (result === null ) {
if (result === null) {
return null;
}
return result > 0;
Expand All @@ -427,7 +427,7 @@ function semverGreaterThanEvaluator(condition: Condition, user: OptimizelyUserCo
*/
function semverLessThanEvaluator(condition: Condition, user: OptimizelyUserContext): boolean | null {
const result = evaluateSemanticVersion(condition, user);
if (result === null ) {
if (result === null) {
return null;
}
return result < 0;
Expand All @@ -443,7 +443,7 @@ function semverLessThanEvaluator(condition: Condition, user: OptimizelyUserConte
*/
function semverGreaterThanOrEqualEvaluator(condition: Condition, user: OptimizelyUserContext): boolean | null {
const result = evaluateSemanticVersion(condition, user);
if (result === null ) {
if (result === null) {
return null;
}
return result >= 0;
Expand All @@ -459,9 +459,9 @@ function semverGreaterThanOrEqualEvaluator(condition: Condition, user: Optimizel
*/
function semverLessThanOrEqualEvaluator(condition: Condition, user: OptimizelyUserContext): boolean | null {
const result = evaluateSemanticVersion(condition, user);
if (result === null ) {
if (result === null) {
return null;
}
return result <= 0;

}
14 changes: 7 additions & 7 deletions packages/optimizely-sdk/lib/core/decision_service/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ export class DecisionService {
* @param {ruleKey} ruleKey A ruleKey (optional).
* @return {DecisionResponse<Variation|null>} DecisionResponse object containing valid variation object and decide reasons.
*/
findValidatedForcedDecision(
findValidatedForcedDecision(
config: ProjectConfig,
user: OptimizelyUserContext,
flagKey: string,
Expand Down Expand Up @@ -1116,10 +1116,10 @@ export class DecisionService {
const forcedDecisionResponse = this.findValidatedForcedDecision(configObj, user, flagKey, rule.key);
decideReasons.push(...forcedDecisionResponse.reasons);

const forcedVariaton = forcedDecisionResponse.result;
if (forcedVariaton) {
const forcedVariation = forcedDecisionResponse.result;
if (forcedVariation) {
return {
result: forcedVariaton.key,
result: forcedVariation.key,
reasons: decideReasons,
};
}
Expand Down Expand Up @@ -1148,10 +1148,10 @@ export class DecisionService {
const forcedDecisionResponse = this.findValidatedForcedDecision(configObj, user, flagKey, rule.key);
decideReasons.push(...forcedDecisionResponse.reasons);

const forcedVariaton = forcedDecisionResponse.result;
if (forcedVariaton) {
const forcedVariation = forcedDecisionResponse.result;
if (forcedVariation) {
return {
result: forcedVariaton,
result: forcedVariation,
reasons: decideReasons,
skipToEveryoneElse,
};
Expand Down
Loading