Skip to content

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Aug 22, 2022

Summary

Add plugin to provide an internal service for ODP GraphQL server access. Should support 3 potential clients for Browser, Node, ReactNative

Test plan

New .spec. files added unit tests

Issues

OASIS-8409

@coveralls
Copy link

coveralls commented Aug 22, 2022

Coverage Status

Coverage decreased (-0.03%) to 96.075% when pulling b4ed7bd on mike/ats-graphql into 7b53fa8 on master.

Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Suggested a few changes. I assume fetch should work in all environments but it will be great if you can check it once for browser, node and react native.

Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Just added a few suggestions.

@mikechu-optimizely mikechu-optimizely merged commit 1a20b08 into master Aug 31, 2022
@mikechu-optimizely mikechu-optimizely deleted the mike/ats-graphql branch August 31, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants