Skip to content

Final eslint styling fixes. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2015
Merged

Final eslint styling fixes. #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = function (grunt) {
module.exports = function(grunt) {
require('load-grunt-config')(grunt)
// load npm tasks
grunt.loadNpmTasks('grunt-karma')
Expand Down
4 changes: 2 additions & 2 deletions src/logging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*eslint-disable no-console */
/* eslint-disable no-console */
/**
* Wraps a Reactor.react invocation in a console.group
*/
Expand Down Expand Up @@ -32,4 +32,4 @@ exports.dispatchEnd = function(state) {
console.groupEnd()
}
}
/*eslint-enable no-console */
/* eslint-enable no-console */
8 changes: 4 additions & 4 deletions src/reactor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ class Reactor {
* @param {Store} store
*/
registerStore(id, store) {
/*eslint-disable no-console */
/* eslint-disable no-console */
console.warn('Deprecation warning: `registerStore` will no longer be supported in 1.1, use `registerStores` instead')
/*eslint-enable no-console */
/* eslint-enable no-console */
var stores = {}
stores[id] = store
this.registerStores(stores)
Expand All @@ -156,9 +156,9 @@ class Reactor {
registerStores(stores) {
each(stores, (store, id) => {
if (this.__stores.get(id)) {
/*eslint-disable no-console */
/* eslint-disable no-console */
console.warn('Store already defined for id = ' + id)
/*eslint-enable no-console */
/* eslint-enable no-console */
}

var initialState = store.getInitialState()
Expand Down
22 changes: 11 additions & 11 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
var webpack = require('webpack');
var webpack = require('webpack')

var genFilename = function(isMin) {
return [
'./dist/nuclear',
(isMin ? '.min' : ''),
'.js'
].join('');
};
'.js',
].join('')
}

var uglifyJsPlugin = new webpack.optimize.UglifyJsPlugin();
var uglifyJsPlugin = new webpack.optimize.UglifyJsPlugin()

module.exports = [
{
Expand All @@ -20,8 +20,8 @@ module.exports = [
},
module: {
loaders: [
{ test: /\.js$/, loader: 'jstransform-loader' }
]
{ test: /\.js$/, loader: 'jstransform-loader' },
],
},
},
{
Expand All @@ -33,9 +33,9 @@ module.exports = [
},
module: {
loaders: [
{ test: /\.js$/, loader: 'jstransform-loader' }
]
{ test: /\.js$/, loader: 'jstransform-loader' },
],
},
plugins: [uglifyJsPlugin],
}
];
},
]