Skip to content

[AQUA] Refactor evaluation service config to remove redundant information. #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

mrDzurb
Copy link
Member

@mrDzurb mrDzurb commented Mar 9, 2025

Description

Currently, evaluation-related configurations are stored in the container_index.json file. However, due to recent changes, some portions of these configurations have been moved to the SMC level, making certain entries redundant in container_index.json.

This PR involves:

  • Refactoring EvaluationServiceConfig to remove obsolete evaluation configurations and keep only UI-related information.
  • Updating the SDK logic that loads and parses the evaluation configuration, ensuring it retrieves relevant data from the correct sources.
  • Testing to confirm that removing redundant configurations does not affect functionality.

Related changes

  • Refactoring container_index.json to remove obsolete evaluation configurations and keep only UI-related information.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 9, 2025
Copy link

github-actions bot commented Mar 9, 2025

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-58.54%

Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-58.54%

@mrDzurb mrDzurb enabled auto-merge March 10, 2025 17:30
@mrDzurb mrDzurb merged commit 88d6feb into main Mar 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants