-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Uncaught Error: NJS-045: cannot load the oracledb add-on binary for Node.js 7.9.0 #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@kwent This line "The module '/tmp/.org.chromium.Chromium.QS5Iaa'..." seems suspect. What version of Electron are you running? What version of the driver (node-oracledb) are you using? What do you get if you run: Sorry, it's been a while, but when do dependencies of your Electron app get installed/compiled? You may need to pick your Node.js version, then install Electron, then install the driver. After that, don't change your Node.js version unless you want to reinstall Electron and the driver. |
@dmcghan Here is a demo repo i can repro the issue: https://github.com/kwent/electron-react-boilerplate You can download
Let me know what you think... Regards |
@kwent As far as I know, the plan is only to support Node.js versions that have LTS (even numbers). I'm kinda surprised Electron is using odd numbers... Are you unable to compile the binaries? What do you get with this? |
@kwent I'm happy to look into this more for you, but I'm unable to reproduce with the links you provided. Please provide a script I can use to reproduce (or steps). |
@dmcghan To repro: $ git clone [email protected]:kwent/electron-react-boilerplate.git
$ cd electron-react-boilerplate
$ cd app && yarn && cd ..
$ yarn
$ npm run dev (open developer tools to see error message) I'm having issues building from source cause |
@dmcghan Basically generate precompile binaries for module ABI 54 would fix my issue. Is this something possible to do ? Regards |
@kwent That script didn't work for me... Can you upgrade electron? Is the latest version using Node.js 8? |
Not yet. It’s in beta only for now
…On Sat, Dec 30, 2017 at 11:50 PM Dan McGhan ***@***.***> wrote:
@kwent <https://github.com/kwent> That script didn't work for me...
Can you upgrade electron? Is the latest version using Node.js 8?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#818 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA1spOdnVcVGiXDgSXFhgpLluILvjL9lks5tFr4ngaJpZM4ROOPJ>
.
|
There is some info on using yarn with node-oracledb in #794 (comment) I'd really prefer not to release pre-built binaries for Node 7, since that adds another factor to testing. |
I'm going to wait for |
Ok so
I tried to load the > require('\\\\?\\C:\\Users\\kwent\\AppData\\Local\\Temp\\0beacf03-4f41-4b69-b407-0229886d6e9d.tmp.node')
Error: Module did not self-register.
at Object.Module._extensions..node (module.js:664:18)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)ta\\Local\\Temp\\0beacf03-4f41-4b69-b407-0229886d6e9d.tmp.node')
at Function.Module._load (module.js:489:3)ppData\Local\Temp\0beacf03-4f41-4b69-b407-0229886d6e9d.tmp.node'
at Module.require (module.js:579:17)(module.js:536:15)
at require (internal/module.js:11:18)66:25)
at repl:1:1equire (module.js:579:17)
at ContextifyScript.Script.runInThisContext (vm.js:50:33)
at REPLServer.defaultEval (repl.js:240:29)
at bound (domain.js:301:14)runInThisContext (vm.js:50:33) When removing > require('C:\\Users\\kwent\\AppData\\Local\\Temp\\0beacf03-4f41-4b69-b407-0229886d6e9d.tmp.node')
{ Oracledb: [Function: Oracledb],
Connection: [Function: Connection],
Pool: [Function: Pool],
ResultSet: [Function: ResultSet],
ILob: [Function: ILob] } This thread might help: Any idea ? Edit: After digging more i found same issue here: sass/node-sass#2149 I tried > const trueCasePathSync = require('true-case-path')
> require(trueCasePathSync('\\\\?\\C:\\Users\\kwent\\AppData\\Local\\Temp\\0beacf03-4f41-4b69-b407-0229886d6e9d.tmp.node'))
{ Oracledb: [Function: Oracledb],
Connection: [Function: Connection],
Pool: [Function: Pool],
ResultSet: [Function: ResultSet],
ILob: [Function: ILob] } Works well. So i think this is the fix ! Regards |
@kwent good detective work; I'm sure that will help someone. |
@kwent The problem with |
@cjbj Sure although if we wanna make this library compatible for all nodejs version, we better have another fix here. It's what |
Might actually be another bug... will come back to you after some more tests. |
Bug might come from https://github.com/chentsulin/electron-react-boilerplate To repro (windows):
Follow up here: electron-react-boilerplate/electron-react-boilerplate#1419 Regards |
I'm still confused. Any help is welcome. I still don't know if it's coming from this library, or something wrong in the |
@cjbj I would need a precompiled library for Node.js 7.9.0 (NODE_MODULE_VERSION=51) for Windows. This version of Node is used by electron in VSCode, for which I'm trying to develop an extension using oracledb. According to this topic, Node version of electron "cannot be changed" there. I have troubles in compiling oracledb from source code because of the proxy issues. What may be an idea to make oracledb work with node 7.9.0? |
@dtaipov One workaround is to upgrade electron to 1.8.2 |
This issue has been fixed with #851. Closing. Thanks ! |
@dtaipov If you have proxy issues check out https://oracle.github.io/node-oracledb/INSTALL.html#offline and https://oracle.github.io/node-oracledb/INSTALL.html#github |
it's work for me. |
Uh oh!
There was an error while loading. Please reload this page.
Hi,
So i spent a fair amount of time trying to make my electron app works. I followed the installation guide with Zip File method but i hit the issue below which prevent the all app to start.
The system node version used is v8.2.0. So i have no idea why the error message is mentioning v7.9.0 ?
I installed nvm and switch to 7.9.0 version and same issue.
Not sure about NODE_MODULE_VERSION message as well. 54 is referencing to any nodejs version when i take a look at the official page: https://nodejs.org/en/download/releases/
I tried to rebuild extension but nothing i get stuck with this message. Any idea ?
Regards
The text was updated successfully, but these errors were encountered: