Skip to content

Changed value of wlst_type field under the "ForeignJNDILink" folder, … #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mwooten
Copy link
Contributor

@mwooten mwooten commented Mar 19, 2018

Hi Carolyn,

I changed the value of the wlst_type field to "ForeignJNDILink${:s}", then created and ran (but didn't commit) the following unittest to verify the correct value was being returned:

def testIssue28Fix(self):
location=LocationContext().append_location(FOLDERS.FOREIGN_JNDI_PROVIDER)
token = self.aliases.get_name_token(location)
location.add_name_token(token, 'ForeignJNDIProvider-0')
location.append_location(FOLDERS.FOREIGN_JNDI_PROVIDER_LINK)
token = self.aliases.get_name_token(location)
location.add_name_token(token, 'ForeignJNDILink-0')

wlst_mbean_type = **self.aliases.get_wlst_mbean_type(location)
expected = FOLDERS.FOREIGN_JNDI_PROVIDER_LINK**
self.assertEqual(wlst_mbean_type, expected)

wlst_mbean_type = **self.online_aliases.get_wlst_mbean_type(location)
expected = '%ss' % FOLDERS.FOREIGN_JNDI_PROVIDER_LINK**
self.assertEqual(wlst_mbean_type, expected)

return

@mwooten mwooten requested a review from CarolynRountree March 19, 2018 20:35
@CarolynRountree CarolynRountree merged commit 55f10d4 into master Mar 19, 2018
@mwooten mwooten deleted the Issue#28-Fix-wlst_type-for-ForeignJNDIProviders/ForeignJNDILinks branch April 4, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants