Fix for top level removal between models #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsharpe
reviewed
Jul 30, 2020
| @@ -190,6 +190,60 @@ def testCompareModelInvalidFile(self): | |||
|
|
|||
| self.assertNotEqual(return_code, 0) | |||
|
|
|||
| def testDeleteModelAppDeploymentsRemoved(self): | |||
There was a problem hiding this comment.
Is this like a double negative? Delete ... Removed. Please add a comment, or change the name of the method to clarify the intent.
rakillen
approved these changes
Jul 30, 2020
Fix double negative in test name
rakillen
reviewed
Jul 30, 2020
| @@ -190,7 +190,7 @@ def testCompareModelInvalidFile(self): | |||
|
|
|||
| self.assertNotEqual(return_code, 0) | |||
|
|
|||
| def testDeleteModelAppDeploymentsRemoved(self): | |||
| def testDeleteModelAppDeployments(self): | |||
| _method_name = 'testCompareModelFull' | |||
ddsharpe
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a lot of testing and found only the removal of a top level causes the problem. Problem due to an undefined variable.
Fixes Jira WDT-436